remove HMSHandler#lowerCaseConvertPartName

wecharyu · Dec 26, 2023 · 7c08241 · 7c08241
1 parent 5af0f18
commit 7c08241
Showing 1 changed file with 8 additions and 32 deletions.
diff --git a/...metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java b/...metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
@@ -6781,28 +6781,6 @@ public Map<String, String> partition_name_to_spec(String part_name) throws TExce
     return Warehouse.makeSpecFromName(part_name);
   }
 
-  public static String lowerCaseConvertPartName(String partName) throws MetaException {
-    if (partName == null) {
-      return partName;
-    }
-    boolean isFirst = true;
-    Map<String, String> partSpec = Warehouse.makeEscSpecFromName(partName);
-    String convertedPartName = new String();
-
-    for (Map.Entry<String, String> entry : partSpec.entrySet()) {
-      String partColName = entry.getKey();
-      String partColVal = entry.getValue();
-
-      if (!isFirst) {
-        convertedPartName += "/";
-      } else {
-        isFirst = false;
-      }
-      convertedPartName += partColName.toLowerCase() + "=" + partColVal;
-    }
-    return convertedPartName;
-  }
-
   @Override
   @Deprecated
   public ColumnStatistics get_table_column_statistics(String dbName, String tableName,
@@ -6870,16 +6848,15 @@ public ColumnStatistics get_partition_column_statistics(String dbName, String ta
     String[] parsedDbName = parseDbName(dbName, conf);
     tableName = tableName.toLowerCase();
     colName = colName.toLowerCase();
-    String convertedPartName = lowerCaseConvertPartName(partName);
     startFunction("get_column_statistics_by_partition", ": table=" +
         TableName.getQualified(parsedDbName[CAT_NAME], parsedDbName[DB_NAME],
-            tableName) + " partition=" + convertedPartName + " column=" + colName);
+            tableName) + " partition=" + partName + " column=" + colName);
     ColumnStatistics statsObj = null;
 
     try {
       List<ColumnStatistics> list = getMS().getPartitionColumnStatistics(
           parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
-          Lists.newArrayList(convertedPartName), Lists.newArrayList(colName),
+          Lists.newArrayList(partName), Lists.newArrayList(colName),
           "hive");
       if (list.isEmpty()) {
         return null;
@@ -7004,7 +6981,7 @@ private void normalizeColStatsInput(ColumnStatistics colStats) throws MetaExcept
     statsDesc.setCatName(statsDesc.isSetCatName() ? statsDesc.getCatName().toLowerCase() : getDefaultCatalog(conf));
     statsDesc.setDbName(statsDesc.getDbName().toLowerCase());
     statsDesc.setTableName(statsDesc.getTableName().toLowerCase());
-    statsDesc.setPartName(lowerCaseConvertPartName(statsDesc.getPartName()));
+    statsDesc.setPartName(statsDesc.getPartName());
     long time = System.currentTimeMillis() / 1000;
     statsDesc.setLastAnalyzed(time);
 
@@ -7163,15 +7140,14 @@ public boolean delete_partition_column_statistics(String dbName, String tableNam
     if (colName != null) {
       colName = colName.toLowerCase();
     }
-    String convertedPartName = lowerCaseConvertPartName(partName);
     startFunction("delete_column_statistics_by_partition",": table=" +
         TableName.getQualified(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName) +
-        " partition=" + convertedPartName + " column=" + colName);
+        " partition=" + partName + " column=" + colName);
     boolean ret = false, committed = false;
 
     getMS().openTransaction();
     try {
-      List<String> partVals = getPartValsFromName(getMS(), parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, convertedPartName);
+      List<String> partVals = getPartValsFromName(getMS(), parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, partName);
       Table table = getMS().getTable(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName);
       // This API looks unused; if it were used we'd need to update stats state and write ID.
       // We cannot just randomly nuke some txn stats.
@@ -7180,19 +7156,19 @@ public boolean delete_partition_column_statistics(String dbName, String tableNam
       }
 
       ret = getMS().deletePartitionColumnStatistics(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
-          convertedPartName, partVals, colName, engine);
+          partName, partVals, colName, engine);
       if (ret) {
         if (transactionalListeners != null && !transactionalListeners.isEmpty()) {
           MetaStoreListenerNotifier.notifyEvent(transactionalListeners,
               EventType.DELETE_PARTITION_COLUMN_STAT,
               new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
-                  convertedPartName, partVals, colName, engine, this));
+                  partName, partVals, colName, engine, this));
         }
         if (!listeners.isEmpty()) {
           MetaStoreListenerNotifier.notifyEvent(listeners,
               EventType.DELETE_PARTITION_COLUMN_STAT,
               new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
-                  convertedPartName, partVals, colName, engine, this));
+                  partName, partVals, colName, engine, this));
         }
       }
       committed = getMS().commitTransaction();