Adding error event emitter #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Hacker0x01#994 can be reproduced when the element is located in Bootstrap grid's .col-*-*
* First working draft of selectTime feature * Added excludeTimePeriod and excludeTimes to API * Changed excludeTimePeriod API to minTime, maxTime | Added docs * Ran 'npm start build' * Passes tests * Commit after rebase from master and npm install * Minor scss fix for time container alignment and fix for missing module in timezone_date.tsx * Fix for making time container be same height as month container * Revert back to old port * Reverted back to default 'L' for dateFormat. Show in examples that dateFormat must be changed to 'LLL' for time to be displayed * Wrote first test for time feature * Fix for failed tests. Also used props instead of passing monthContainer ref with setState * Added more tests for time feature * Changed time styling to match month styling when selected * Code review changes - Removed excessive special casing in scss - Reinstated DontCloseOnSelect - refactored onTimeChange prop name to onChange on Time.tsx - Moved time examples to top of example_components * Removed showTimeSelect from portal examples * Mentioned time picker in README.md * Deleted tether_component.jsx component
* Added support for timeFormat prop Hacker0x01#1034 - Added test case - Updated the docs * Added a default timeFormat - hh:mm A Hacker0x01#1034 * Format was not used Hacker0x01#1034
Fixed typos in README.md
* Remove moment from datepicker.jsx * Remove moment from calendar.jsx * Remove moment from time.jsx * Remove moment from month.jsx * Remove moment from week.jsx * Refactor: Do not export fns that take date units * Remove moment from day.jsx * Remove moment from month_dropdown.jsx * Remove moment from year_dropdown.jsx * Order date_utils, remove more moment calls from datepicker.jsx
* Remove moment from calendar_test * Remove moment from date_utils_test * Refactor repetition of key data * Remove moment from datepicker_test * Remove moment from day_test * Remove moment from exclude_time_period_test * Remove moment from exclude_times_test * Remove moment from month_dropdown_test * Remove moment from month_test * Remove moment from timezone_date_picker * Remove moment from week_test * Remove moment from year_dropdown_test * Fix missed instances of moment calls in datepicker_test * Ignore .DS_Store files (MacOS)
* Adding example for openByDefault * Linting fixes and tests passed
* Change default back to local time * unit test
… to wrap (Hacker0x01#1074) react-popper will place the popover in the same constraints as the parent div. For cases where the parent div is somehow constrained -- a scrollable div -- the popper will appear inside the div and will be constrained by it to. There are cases where you want the popover to be unconstrained it's parent. To do this, you must place the popover in a container outside of the constrained container. Adding a popperContainer would allow a user to implement the following function CalendarContainer (props) { const containerId = document.getElementById('container-outside-root') return ( <Portal container={containerId}> {props.children} </Portal> ) } // somewhere else <DatePicker ... popperContainer={CalendarContainer} /> Which will then permit rendering the control inside the div and the calendar outside the div (which the popper library will connect through the magic of javascript) demo: https://codesandbox.io/s/1ozy5ol5vl
* Downgraded react-onclickoutside to 6.0.0 * Modified by grunt
…der-color-to-vars Extract font color of month and time headers to vars
* Added showTimeSelectOnly prop * Added unit test for showTimeSelectOnly * Added additional unit tests
* Add jsx to prettier lint-staged * Rerun prettier on *.jsx * Fix eslint supression
* Updated react-popper version * Reverted extra unnecessary change
…1329) * Allow specific times outside of intervals to be injected into time list * Update docs-site * Update docs * Add tests * More specs
* Allow multiple times to be injected between each interval * Better format * Tests * Move sorting out of loop
* Adds title attribute to clear button * Changes title attribute to be configurable, adds test, updates docs * Updates clear button to be a button and removes it from tab order
* Convert week_number.jsx to flow (as a simple example) Workaround for react-docgen#125 * Run flow from lint script
handleBlur() calls deferFocusInput() if the date picker is open. deferFocusInput() schedules a later setFocus() call, which didn't make sure the input element is still mounted before focusing it, yielding an unhandled exception.
Fix potential exception after unmounting
Add switch month test, when year is changed
…ion-bug-1345 Bk fix year pre selection bug, fixes Hacker0x01#1345
* Add formatWeekDay props for weekdays custom formatting * pass formatWeekDay prop * expect func
A button in a form gets the type attribute set to submit by default, if the type is not specified. Submitting a form with a clearable datepicker component by pressing enter in a field currently triggers the clearing of the datepicker component, instead of submitting the form. This can be fixed by setting the type attribute of the clear button to "button".
Set type attribute of the clear button to "button"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is our current version, we added this basic error handling to work well with our widgets
Include the
dist/folder in order to install it from github