Remove unused InfoWindow (closes #229).#444
Merged
fschmenger merged 1 commit intoSep 25, 2025
Merged
Conversation
Collaborator
|
Hi @fschmenger, I totally agree with you on this one and suppose this can be removed. As I'm one of the latest contributors though, I'd prefer to let @chrismayer approve the PR as he's certainly aware of the history behind this component... |
chrismayer
approved these changes
Sep 24, 2025
Collaborator
chrismayer
left a comment
There was a problem hiding this comment.
Yes, this can be removed. It is outdated for many years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presumably this module was one of the first Wegue demo windows and has been outdated for a very long time. It hasn't been referenced in the code for many years.
It doesn't follow the module card approach, it doesn't use i18n internationalization and neither was it migrated to Vue3. I think it`s about time to remove it, I hope you agree.