Refactor map recorder tests to avoid Chrome-specific MIME type checks#456
Merged
fschmenger merged 1 commit intoNov 24, 2025
Merged
Conversation
…ndent MIME type assertions - fixes wegue-oss#407.
fschmenger
force-pushed
the
map_recorder_unit_test_revision
branch
from
377904b to
214a7fa
Compare
fschmenger
requested review from
chrismayer and
sronveaux
and removed request for
sronveaux
chrismayer
approved these changes
Nov 21, 2025
Collaborator
chrismayer
left a comment
chrismayer
left a comment
There was a problem hiding this comment.
LGTM, thank you 👍
Feel free to merge at will...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the maintainability of the map recorder tests by removing Chrome-dependent MIME type assertions - as suggested in #407.