Fix vulnerabilities in npm dependencies#469
Conversation
There was a problem hiding this comment.
Hi @chrismayer and thanks for the PR!
I just tested it and everything works as expected!
Just a simple comment, wouldn't it also be useful to change Vite version inside the package.json file?
This would mean replacing the "vite": "^7.1.9", line with "vite": "^7.3.0", to align with package-lock.json...
Someone doing npm i will arrive at the same result anyway, so I let you choose whether to do it or not. It is ready to merge from my point of view.
Please also know that I'll have two weeks off after tomorrow so I'm not sure I'll have time to review the other PRs you made with the other things I have to finish for that time...
Enjoy the end of the year and merry Christmas!
chrismayer
force-pushed
the
fix-vulnerabilities
branch
from
448a44b to
aa38e2c
Compare
chrismayer
force-pushed
the
fix-vulnerabilities
branch
from
aa38e2c to
9b57ff7
Compare
|
Thanks @sronveaux for your review. I like the idea of grading up explicitly to Going to merge now. Merry Christmas to all 🎄 |
2 participants
This fixes the current vulnerabilities in the npm dependencies.