Make Geocoding tests w/ remote service optional#470
Closed
chrismayer wants to merge 1 commit into
Closed
Conversation
chrismayer
force-pushed
the
opt-fail-geocode-remote-service
branch
3 times, most recently
from
df8bb48 to
7fe397a
Compare
chrismayer
force-pushed
the
opt-fail-geocode-remote-service
branch
from
7fe397a to
9d90535
Compare
Collaborator
Author
|
Closed in favor of #472 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that our unit test suite does not fail in case the remote Geocoding service is not available. This service is external and unrelated to Wegue and thus leading to misleading unit test failures.
If the "real" Geocoding API fails in the tests this is now caught and the tests are skipped. Only real error are forwarded, so the test suite fails.