Skip to content

Do not reverse the list of map layers. #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fschmenger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not reverse the list of map layers. #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4988516
Do not reverse the list of map layers.
fschmenger May 11, 2026
b2dd511
Fix layer order in unit tests for PermalinkController.
fschmenger May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/attributeTable/AttributeTableWin.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ export default {
layer instanceof VectorLayer &&
layer.get('lid') !== 'wgu-measure-layer' &&
layer.get('lid') !== 'wgu-geolocator-layer'
)
.reverse();
);
},
/**
* Reactive property to return the items object to bind to the selection menu.
Expand Down
3 changes: 1 addition & 2 deletions src/components/bglayerswitcher/BgLayerList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ export default {
*/
displayedLayers () {
return this.layers
.filter(layer => layer.get('isBaseLayer'))
.reverse();
.filter(layer => layer.get('isBaseLayer'));
},
/**
* Reactive property to return the currently visible OpenLayers background layer ID.
Expand Down
3 changes: 1 addition & 2 deletions src/components/layerlist/LayerList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ export default {
*/
displayedLayers () {
return this.layers
.filter(layer => layer.get('displayInLayerList') !== false && !layer.get('isBaseLayer'))
.reverse();
.filter(layer => layer.get('displayInLayerList') !== false && !layer.get('isBaseLayer'));
}
}
};
Expand Down
2 changes: 1 addition & 1 deletion src/components/ol/Map.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export default {
const layers = [];
const appConfig = this.$appConfig;
const mapLayersConfig = appConfig.mapLayers || [];
mapLayersConfig.reverse().forEach(function (lConf) {
mapLayersConfig.forEach(function (lConf) {
// Some Layers may require a TileGrid object
// Remarks: Passing null instead of undefined as parameters into the
// constructor of OpenLayers sources overwrites OpenLayers defaults.
Expand Down
1 change: 0 additions & 1 deletion src/components/overviewmap/OverviewMapPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export default {
selectedBgLayer () {
return this.layers
.filter(layer => layer.get('isBaseLayer'))
.reverse()
.find(layer => layer.getVisible());
}
},
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/specs/components/ol/PermalinkController.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ describe('ol/Map.vue', () => {
}
});

expect(vm.permalinkController.getParamStr()).to.equal('#z=' + newZoom + '&c=8.9832%2C17.6789&r=0&l=ahocevar-imagewms%2Cahocevar-wms%2Cosm-bg');
expect(vm.permalinkController.getParamStr()).to.equal('#z=' + newZoom + '&c=8.9832%2C17.6789&r=0&l=osm-bg%2Cahocevar-wms%2Cahocevar-imagewms');
});

afterEach(() => {
Expand Down
Loading