Fix consumer is never called when extract uncompressed 0 byte entry #190
Conversation
| do { | ||
| _ = try archive.extract(entry, progress: progress) { (data) in | ||
| // Progress does not finished because Progress assumes totalUnitCount > 0 | ||
| // XCTAssertFalse(progress.isFinished) |
There was a problem hiding this comment.
When extract 0byte entry, Progress#isFinished returns false.
I don't know it is good way or not...
https://developer.apple.com/documentation/foundation/progress
IMO, It is intuitive that Progress has 1/1 progress for extracting 0byte entry.
There was a problem hiding this comment.
This is a good point - we currently don't handle this edge case properly.
We are using a 1/1 progress for entries of type .directory already and could also use the same approach for zero-byte files.
Since this PR handles the bug where the completion handler is not called for zero-byte files, I removed the progress related code from the test case you provided. I think the progress mis-reporting should be handled in a dedicated PR.
There was a problem hiding this comment.
We are using a 1/1 progress for entries of type .directory already and could also use the same approach for zero-byte files.
It looks good to me. thanks!
|
Thanks for providing this PR - good catch! I saw that you also filed a similar issue for compressed entries: #191 |
Hmm. In my memory, method is different betweeon compressed and uncompressed entry... (It's the reason I created an another issue) |
Fixes #
Changes proposed in this PR
consumeris never called while extracting 0 byte entry from uncompressed archive.Tests performed
testExtractUncompressedEmptyFiletestExtractUncompressedEmptyFile.zipis copy fromtestExtractUncompressedDataDescriptorArchive.zipFurther info for the reviewer
Open Issues
N/A