Skip to content

Loosen DOMString? getter to accommodate ARIA-style string reflection #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Loosen DOMString? getter to accommodate ARIA-style string reflection #10974

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e013f33
Modify DOMString? getter to allow non-enumerated attribute values
Jan 31, 2025
56f728a
Add myself to acknowledgements per contribution guidelines
Jan 31, 2025
17e914e
Fix spacing to be single-space indented
Feb 16, 2025
e0f23ab
Re-implement asserts for limited to known values/known state; remove …
Feb 22, 2025
460b1de
Fix indentation
Feb 22, 2025
f5677bb
Add non-enumerated check to return empty string in that case
Feb 22, 2025
f3041f9
Remove empty string step
Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8197,20 +8197,25 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
content attribute whose namespace is null and local name is the <span>reflected content
attribute name</span>.

<li><p><span>Assert</span>: <var>attributeDefinition</var> indicates it is an <span>enumerated
attribute</span>.</p></li>
<li>
<p>If <var>attributeDefinition</var> indicates it is an <span>enumerated attribute</span>:</p>

<li><p><span>Assert</span>: the <span>reflected IDL attribute</span> is <span>limited to only
known values</span>.</p></li>
<ol>
<li><p><span>Assert</span>: the <span>reflected IDL attribute</span> is <span>limited to only
known values</span>.</p></li>

<li><p><span>Assert</span>: <var>contentAttributeValue</var> corresponds to a state of
<var>attributeDefinition</var>.</p></li>
<li><p><span>Assert</span>: <var>contentAttributeValue</var> corresponds to a state of
<var>attributeDefinition</var>.</p></li>

<li><p>If <var>contentAttributeValue</var> corresponds to a state of
<var>attributeDefinition</var> with no associated keyword value, then return null.</p></li>
<li><p>If <var>contentAttributeValue</var> corresponds to a state of
<var>attributeDefinition</var> with no associated keyword value, then return null.</p></li>

<li><p>Return the <span>canonical keyword</span> for the state of
<var>attributeDefinition</var> that <var>contentAttributeValue</var> corresponds to.</p></li>
<li><p>Return the <span>canonical keyword</span> for the state of
<var>attributeDefinition</var> that <var>contentAttributeValue</var> corresponds to.</p></li>
</ol>
</li>

<li><p>Return <var>contentAttributeValue</var>.</p></li>
</ol>
</li>

Expand Down Expand Up @@ -146899,6 +146904,7 @@ INSERT INTERFACES HERE
Rachid Finge,
Rafael Weinstein,
Rafa&#x0142; Mi&#x0142;ecki,
Rahim Abdi,
Rahul Purohit,
Raj Doshi,
Rajas Moonka,
Expand Down