Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: update WPT #1264

Closed
wants to merge 2 commits into from
Closed

Conversation

MattiasBuelens
Copy link
Collaborator

It looks like it's been a while since we synced the reference implementation with the latest WPT. This aims to fix that.

The following errors came up:

@MattiasBuelens MattiasBuelens requested a review from domenic April 4, 2023 21:24
@ricea
Copy link
Collaborator

ricea commented Apr 5, 2023

I'm not entirely sure what the intention was here: does the spec need to be updated for this? confused

Yes. This is #1243. We plan to update the spec to require a microtask between enqueue() and write(), but we haven't done it yet.

@youennf
Copy link
Contributor

youennf commented May 24, 2023

Yes. This is #1243. We plan to update the spec to require a microtask between enqueue() and write(), but we haven't done it yet.

Is #1243 easily resolvable?
Another approach would be to move this specific test in a separate file and disable it in this repo until #1243 can be resolved.

@youennf youennf mentioned this pull request Jun 7, 2023
@youennf
Copy link
Contributor

youennf commented Jun 7, 2023

#1282 is a new attempt at fixing the same issue.
It basically takes this PR and add a few additional changes. PR CI is green.

@youennf
Copy link
Contributor

youennf commented Jun 7, 2023

Shall we close this one?

@MattiasBuelens
Copy link
Collaborator Author

Closing, because superseded by #1282.

@MattiasBuelens MattiasBuelens deleted the update-wpt branch June 7, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants