Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxShareToBeSold and maxShareToBond are not validated #303

Closed
clemlak opened this issue Jan 27, 2025 · 0 comments · Fixed by #333
Closed

maxShareToBeSold and maxShareToBond are not validated #303

clemlak opened this issue Jan 27, 2025 · 0 comments · Fixed by #333
Assignees
@clemlak
Labels
🐛 bug Something isn't working 🦄 v3 Related to Uniswap V3 integration

Comments

@clemlak
Copy link
Collaborator

clemlak commented Jan 27, 2025

Small issue but maxShareToBeSold and maxShareToBond are never validated, this could lead to transactions reverting without any explanations and annoying debugging sessions.
@clemlak clemlak added the 🐛 bug Something isn't working label Jan 27, 2025
@clemlak clemlak self-assigned this Jan 27, 2025
@aadams aadams added the 🦄 v3 Related to Uniswap V3 integration label Feb 4, 2025
@clemlak clemlak linked a pull request Feb 6, 2025 that will close this issue
Buncha fixes #333
Merged
@clemlak clemlak removed a link to a pull request Feb 10, 2025
Buncha fixes #333
Merged
@clemlak clemlak linked a pull request Feb 10, 2025 that will close this issue
Buncha fixes #333
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemlak clemlak

Labels
🐛 bug Something isn't working 🦄 v3 Related to Uniswap V3 integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Buncha fixes whetstoneresearch/doppler
2 participants
@aadams @clemlak