Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buncha fixes #333

Merged
merged 45 commits into from
Feb 11, 2025
Merged

Buncha fixes #333

merged 45 commits into from
Feb 11, 2025

Conversation

clemlak
Copy link
Collaborator

@clemlak clemlak commented Feb 4, 2025

  • GovernorSettings is not using hardcoded constructor parameters anymore
  • LP tokens are now locked in the UniswapV2Locker for 1 year and anyone can call the unlock function
  • Lock pool on asset creation
  • Fees calculation in Airlock was fixed and refactored (overflow when no fees), note that the protocol / integrator fees getters were renamed
  • V1 deployment script was added
  • Deposit amounts calculation was patched (see MigrationMath)
  • More stuff, see the commits...

@clemlak clemlak linked an issue Feb 6, 2025 that may be closed by this pull request
@clemlak clemlak marked this pull request as ready for review February 7, 2025 07:57
Copy link
Contributor

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change in script; but core logic changes looked OK to me

@clemlak clemlak merged commit bf678a4 into main Feb 11, 2025
1 check passed
@clemlak clemlak deleted the buncha-fixes branch February 11, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment