-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buncha fixes #333
Merged
Merged
Buncha fixes #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clemlak
commented
Feb 4, 2025
•
edited
Loading
edited
- GovernorSettings is not using hardcoded constructor parameters anymore
- LP tokens are now locked in the UniswapV2Locker for 1 year and anyone can call the unlock function
- Lock pool on asset creation
- Fees calculation in Airlock was fixed and refactored (overflow when no fees), note that the protocol / integrator fees getters were renamed
- V1 deployment script was added
- Deposit amounts calculation was patched (see MigrationMath)
- More stuff, see the commits...
This was
linked to
issues
Feb 5, 2025
This was
linked to
issues
Feb 5, 2025
This was
unlinked from
issues
Feb 10, 2025
This was
linked to
issues
Feb 10, 2025
saucepoint
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change in script; but core logic changes looked OK to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.