Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxDutchAuctionTest
-- in this test we are swapping for exactly 1 asset, warping +1 epoch, then swapping that 1 asset back in. This causes thenetSold
to be <= 0 to trigger the max DA test. In this test we were checking that the lowerSlug was unset, but this will not be the case given that when we warp +1 epoch after the first swap we will be partially dutch auctioning down. Because of the partial dutch auction we will not be taking out all of the numeraire token, and thus the lower slug is NOT unset.assetAvailable
being passed to_computePriceDiscoverySlug
. Previously, we were computingassetAvailable
after clearing the slugs and then passingassetAvailable
tocomputeUpperSlugData
. IncomputeUpperSlugData
we subtract the asset tokens allocated to the upper slug fromassetAvailable
, but this operation is done locally in thecomputeUpperSlugData
scope and was not effectively propagated to the parent function call. Now we return a new valueassetRemaining
fromcomputeUpperSlugData
such that we have a correct accounting of the tokens available for the price discovery slugs. (flagged in Check thatassetAvailable
is correct #103)isToken0 == true