Fix !isToken0 && fee != 0 && protocolFee != 0 test cases #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kinrezC
commented
Oct 22, 2024
•
kinrezC
commented
- Fixes !isToken0 test cases
- Fixes FEE=30 tests
- Fixes FEE=30 && PROTOCOL_FEE=50 tests
… fix relative dutch auction assertions
kinrezC
changed the title
kadenzipfel
requested changes
Oct 23, 2024
| forge test -vvv --via-ir | ||
| id: test1 | ||
|
|
||
| - name: Run forge tests isToken0 (true) fee (300) protocolFee (50) | ||
| run: | | ||
| export IS_TOKEN_0=TRUE | ||
| export FEE=300 | ||
| export FEE=30 | ||
| export PROTOCOL_FEE=50 | ||
| forge test -vvv --via-ir | ||
| id: test2 |
There was a problem hiding this comment.
We should add a run with USING_ETH=TRUE here as well
There was a problem hiding this comment.
Nvm, I see this is done in #154
Comment on lines
220
to
+227
| } | ||
| } else { | ||
| revert InvalidSwapAfterMaturitySufficientProceeds(); | ||
| } | ||
| } | ||
|
|
||
| if (block.timestamp > endingTime && !insufficientProceeds) { | ||
| revert InvalidSwapAfterMaturitySufficientProceeds(); | ||
| } | ||
|
|
There was a problem hiding this comment.
What's the reason for moving this? Are they not logically the same since if state.totalProceeds < minimumProceeds, we set insufficientProceeds = true?
There was a problem hiding this comment.
Yeah i think this was an artifact of me debugging, I will revert it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.