Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVF-3, CVF-4, CVF-5, CVF-11, CVF-12 #181

Merged
merged 5 commits into from
Nov 3, 2024
Merged

CVF-3, CVF-4, CVF-5, CVF-11, CVF-12 #181

merged 5 commits into from
Nov 3, 2024

Conversation

clemlak
Copy link
Collaborator

@clemlak clemlak commented Nov 2, 2024

Overflow is possible in unsafe type conversion.

I think it's a bit unlikely to happen because the values should be extremely large but better be safe than sorry.

@clemlak clemlak changed the title CVF-3 CVF-3, CVF-4 Nov 3, 2024
@clemlak clemlak changed the title CVF-3, CVF-4 CVF-3, CVF-4, CVF-5 Nov 3, 2024
@clemlak clemlak changed the title CVF-3, CVF-4, CVF-5 CVF-3, CVF-4, CVF-5, CVF-11 Nov 3, 2024
@clemlak clemlak changed the title CVF-3, CVF-4, CVF-5, CVF-11 CVF-3, CVF-4, CVF-5, CVF-11, CVF-12 Nov 3, 2024
kinrezC
kinrezC reviewed Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@kinrezC kinrezC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetGammaShare can be an immutable that we compute in the constructor

@kinrezC kinrezC merged commit b8966ee into main Nov 3, 2024
1 check passed
@kinrezC kinrezC deleted the post-abdk-audit/3 branch November 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinrezC kinrezC kinrezC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemlak @kinrezC