Skip to content

Conversation

@Nyholm
Copy link

@Nyholm Nyholm commented Jul 14, 2014

I did aslo fix the build matrix

I did aslo fix the build matrix
@egeloen
Copy link
Contributor

egeloen commented Jul 14, 2014

Can you update your PR in order to match this change? egeloen/IvoryLuceneSearchBundle@29acad2 Basically, I would like to be sure everything will work with all Symfony/PHP versions combined. Additionally, you need to update the require composer command in order to be able to install the Symfony master version

@Nyholm
Copy link
Author

Nyholm commented Jul 18, 2014

That change you are referring to is not preferable. It will just create a awful lots of builds and they are redundant.
You want to test this bundle agains multiple PHP versions. You do also want to test this bundle against multiple Symfony versions. The combination is not interesting because the integration will not differ between PHP versions. You have to trust the Symfony core guys to run their test suite in different PHP environments. (And they do)

I've updated the composer command as you recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants