Skip to content

Update rstest dev-dependency to 0.26#17

Merged
wiktor-k merged 3 commits into
wiktor-k:mainfrom
musicinmybrain:rstest-0.26
Aug 8, 2025
Merged

Update rstest dev-dependency to 0.26#17
wiktor-k merged 3 commits into
wiktor-k:mainfrom
musicinmybrain:rstest-0.26

Conversation

@musicinmybrain

Copy link
Copy Markdown
Contributor

Updates rstest to the latest release. Since rstest is just a dev-dependency for a trivial doctest, the very minor incompatibilities across rstest versions are not relevant, and I confirmed that cargo test still passes. I updated Cargo.lock using cargo update rstest.

@wiktor-k

wiktor-k commented Aug 7, 2025

Copy link
Copy Markdown
Owner

This looks good in general 👌

Two issues that the CI reported: missing sign off (see CONTRIBUTING.md) and some issue with the deny plugin. I see it has a v2 now. If you want to try to adjust it, you could do that in this PR. If not, I can do that later and then we rebase this PR.

Anyway, thanks for your contribution! 👋

Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
@musicinmybrain

Copy link
Copy Markdown
Contributor Author

I’ve added the signoff and attempted to update the deny plugin. We’ll see if it works.

Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
@musicinmybrain

Copy link
Copy Markdown
Contributor Author

I updated futures-* crates in Cargo.lock, since a local cargo deny check complained about yanked futures-util 0.3.30. (It looks like this upstream has the habit of yanking every releases but the current one: https://crates.io/crates/futures-util/versions)

@wiktor-k

wiktor-k commented Aug 8, 2025

Copy link
Copy Markdown
Owner

It looks like this upstream has the habit of yanking every releases but the current one

Apparently it's by design and all these old releases were buggy:

rust-lang/futures-rs#2502

https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md

Oh, well.

PR looks great - merging. Thanks again for your time and see you later!

@wiktor-k wiktor-k merged commit 3688308 into wiktor-k:main Aug 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants