feat: display Github REST API rate limit information#1680
Open
silentJET85 wants to merge 2 commits intowimpysworld:mainfrom
Open
feat: display Github REST API rate limit information#1680silentJET85 wants to merge 2 commits intowimpysworld:mainfrom
silentJET85 wants to merge 2 commits intowimpysworld:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Small focused change (23 lines) improving GitHub API error handling and rate limit reporting. Adds better diagnostics for 401 errors and rate limit visibility. No destructive operations, no security风险
silentJET85
force-pushed
the
ratelimit-info
branch
from
0ba3b8c to
17b19d4
Compare
Contributor
Author
|
I'm going to need to tweak this a bit more to work properly with the |
silentJET85
force-pushed
the
ratelimit-info
branch
from
17b19d4 to
53364ae
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- Running as root can hit a
bash: : command not founderror whenELEVATEis empty, so headers aren’t captured and the rate-limit logic fails indeb-get. - This is a moderate, configuration-dependent issue rather than a broad regression, so merge risk looks low overall.
- Pay close attention to
deb-get- guard emptyELEVATEto avoid breaking header capture and rate-limit handling.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="deb-get">
<violation number="1" location="deb-get:185">
P2: Quoting an empty ELEVATE in the process substitution causes `bash: : command not found` when running as root, so headers aren’t captured and rate-limit logic fails.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1630
This PR adds the ability for deb-get to display information about the Github rate limit whenever you install or update an app that installs from Github.
It will show how many requests you have used, how many are remaining, and how many you have total.
It will also show a reminder if you haven't set a
DEBGET_TOKEN. If yourDEBGET_TOKENis invalid, it will show a message for that too.Here are some examples of output in different scenarios:
Trying to install when your DEBGET_TOKEN is invalid:
Trying to install when the rate limit has been reached:
Installing without a token set:
Installing with a token: