Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main build is failing after merging VSCode workspace PR 3929 #4099

Closed
16 tasks done
staycoolcall911 opened this issue Sep 6, 2023 · 4 comments · Fixed by #4115
Closed
16 tasks done

Main build is failing after merging VSCode workspace PR 3929 #4099

staycoolcall911 opened this issue Sep 6, 2023 · 4 comments · Fixed by #4115
Assignees
@staycoolcall911
Labels
🚒 incident Production incident

Comments

@staycoolcall911
Copy link
Contributor

staycoolcall911 commented Sep 6, 2023 •
edited
Loading

Incident description

After merging the following PR to main the build failed:
Failed github action

We're currently looking into it and will revert if we can't find a fix soon.

Is there a workaround?

No response

Incident Response Checklist

  • CREATE this issue (fill up the title, description and submit), then follow the next steps.
  • PIN the incident issue.
  • ACKNOWLEDGE the incident on PagerDuty.
  • ACKNOWLEDGE the incident on BetterStack.
  • WORKAROUND - if there is one, make sure it is documented in the section above.
  • PRIORITIZE (P0/P1/P2 - see the definitions here).
  • (optional) CONTACT a relevant person who has more information about the incident.
  • (optional) ANNOUNCE major incidents on Slack #dev or #general channels. "NOTICE - P0 incident started. {incident-description}. Track on {link to issue}".
  • HANDLE by reverting or forward fixing.
  • UPDATE the team on your actions in the created #alert Slack thread throughout the incident.
  • RESOLVE the incident on PagerDuty (BetterStack resolves automatically).
  • UPDATE the team on the issue closure.
  • (optional) ANNOUNCE closure of major incidents on Slack #dev or #general channels. "NOTICE - P0 incident ended. {incident-resolution-description}. Track on {link to issue}".
  • UNPIN the incident issue.
  • LESSONS LEARNED should be shared via the "post-mortem" workflow on #dev Slack channel.
  • CLOSE the incident issue.
@staycoolcall911 staycoolcall911 added the 🚒 incident Production incident label Sep 6, 2023
@monadabot monadabot added this to Wing Sep 6, 2023
@staycoolcall911 staycoolcall911 pinned this issue Sep 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Sep 6, 2023
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Sep 6, 2023
@staycoolcall911 staycoolcall911 mentioned this issue Sep 6, 2023
Merged
mergify bot pushed a commit that referenced this issue Sep 6, 2023
@staycoolcall911
chore(repo): revert add VS Code workspace file 3929 (#4100)
6344bc0 
Reverts #3929
Because it was failing on Node 20 - see incident #4099
@staycoolcall911 staycoolcall911 unpinned this issue Sep 6, 2023
@staycoolcall911
Copy link
Contributor Author

Reverted PR #3929 via #4100

@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Sep 6, 2023
@staycoolcall911 staycoolcall911 self-assigned this Sep 6, 2023
@skorfmann skorfmann mentioned this issue Sep 6, 2023
Merged
5 tasks
@MarkMcCulloh MarkMcCulloh reopened this Sep 6, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 🤝 Backlog - handoff to owners in Wing Sep 6, 2023
@MarkMcCulloh
Copy link
Contributor

This issue persists intermittently, unrelated to the original trigger

Latest one here https://github.com/winglang/wing/actions/runs/6102723404/job/16561847776

@Chriscbr
Copy link
Contributor

Chriscbr commented Sep 7, 2023 

TypeError: Class extends value undefined is not a constructor or null
 ❯ Object.<anonymous> ../../node_modules/.pnpm/[email protected][email protected]/node_modules/cdktf/lib/terraform-provider.ts:18:49
 ❯ Object.<anonymous> ../../node_modules/.pnpm/[email protected][email protected]/node_modules/cdktf/lib/terraform-module.ts:5:1

@MarkMcCulloh maybe we should try unpinning the cdktf dependency in @winglang/sdk? Feels like it could be related

This was referenced Sep 7, 2023
Closed
Merged
@mergify mergify bot closed this as completed in #4115 Sep 7, 2023
mergify bot pushed a commit that referenced this issue Sep 7, 2023
@MarkMcCulloh
chore: pin node to 20.5.1 in ci (#4115)
442df9a 
Fixes #4099

Waiting for nodejs/node#49497 to be released

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Sep 7, 2023
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.29.6.

mergify bot pushed a commit that referenced this issue Sep 14, 2023
@skorfmann
chore(repo): add VS Code workspace file (take 2) (#4107)
947c97a 
This reverts commit 6344bc0.

I was reverted in #4100 due to #4099 - a hangar test failing on node20. 

Tried to reproduce it locally without success. So, trying it in CI again.

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staycoolcall911 staycoolcall911

Labels
🚒 incident Production incident
Projects
Wing
Archived in project
Milestone
No milestone
4 participants
@MarkMcCulloh @Chriscbr @staycoolcall911 @monadabot