fix: unpin and update cdktf, use "require" for plugin loading #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Console preview environment is available at https://wing-console-pr-4111.fly.dev 🚀 Updated (UTC): 2023-09-07 17:35 |
Chriscbr
approved these changes
Sep 7, 2023
MarkMcCulloh
added
the
🚧 pr/do-not-merge
MarkMcCulloh
force-pushed
the
mark/unpin-cdktf
branch
from
86060ce to
297d468
Compare
MarkMcCulloh
force-pushed
the
mark/unpin-cdktf
branch
from
297d468 to
628134a
Compare
MarkMcCulloh
changed the title
MarkMcCulloh
requested review from
ainvoner,
polamoros,
skyrpex and
eladcon
as code owners
|
Superseded by #4115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #4099
The error in the issue above implies a version mismatch, let's see if this helps.
I decided not to go all the way to 0.18 since I didn't want to deal with larger changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.