Fix benchmark compilation failures#83
Merged
jappeace merged 2 commits intoApr 20, 2026
Merged
Conversation
The binary-parsers-bench benchmark has been broken since v1.1.0 due to two issues: 1. Data.Binary.Parser.Char8 was deleted but HttpReq.hs still imported it. Rewrote the benchmark to use Word8-based combinators from Data.Binary.Parser instead. 2. ReadInt.hs imported GHC.Prim and GHC.Types directly, but ghc-prim was not in build-depends. Replaced with GHC.Exts from base. Also fixed Word8# vs Word# type mismatch in mhDigitToInt by using word8ToWord# conversions. Additionally removed stale haddock reference to the deleted Char8 module. Fixes winterland1989#82 Prompt: Investigate what the hell is going on with this: winterland1989#82 build it locally, reproduce the errors first, then go repair the bugs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpReq.hsbenchmark to useWord8-based combinators fromData.Binary.Parserinstead of the deletedData.Binary.Parser.Char8module (removed in v1.1.0)GHC.Prim/GHC.Typesimports inReadInt.hswithGHC.Extsfrombase, eliminating the need forghc-priminbuild-dependsWord8#vsWord#type mismatch inmhDigitToIntusingword8ToWord#conversionsChar8moduleFixes #82
Test plan
cabal build --enable-benchmarks --enable-testspasses🤖 Generated with Claude Code