Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: crypto-ffi: don't use the base maven-publish plugin #903

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

istankovic
Copy link
Member

The base plugin is missing tasks to publish to Maven Central. Instead, use the high-level plugin, that provides those tasks, but still try to disable javadoc generation.

For POM information it looks like the high-level plugin picks up gradle.properties automatically, so we can remove the

  pomFromGradleProperties()

bit. Actually, we have to remove it, because it's incompatible with the high-level plugin and using it results in an error.

@istankovic istankovic requested a review from a team as a code owner February 4, 2025 14:54
The base plugin is missing tasks to publish to Maven Central.
Instead, use the high-level plugin, that provides those tasks,
but still try to disable javadoc generation.

For POM information it looks like the high-level plugin picks
up gradle.properties automatically, so we can remove the

  pomFromGradleProperties()

bit. Actually, we have to remove it, because it's incompatible with the
high-level plugin and using it results in an error.
@istankovic istankovic force-pushed the ivan/yet-another-publishing-fix branch from 21b19fe to 05226c5 Compare February 4, 2025 14:57
Copy link

github-actions bot commented Feb 4, 2025

🐰 Bencher Report

Branchivan/yet-another-publishing-fix
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
19.09
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.80
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.43
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.90
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.96
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.96
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
989.35
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.77
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84.34
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
220.11
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
427.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
675.99
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
117.25
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.28
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46.09
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.92
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.50
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
95.21
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
19.06
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
115.67
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.99
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
57.41
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
76.20
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.82
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.62
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.76
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.16
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.23
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.93
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22.71
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
31.30
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.72
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
116.85
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
94.29
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
73.22
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
51.97
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
138.38
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.96
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.66
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.03
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
87.76
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.03
🐰 View full continuous benchmarking report in Bencher

@istankovic istankovic merged commit 05226c5 into main Feb 4, 2025
38 checks passed
@istankovic istankovic deleted the ivan/yet-another-publishing-fix branch February 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants