Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: crypto-ffi: remove useless release-build task #921

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

istankovic
Copy link
Member

When running uniffi-bindgen, we rely on the library that was just built for the purpose of linking uniffi-bindgen.

Copy link

github-actions bot commented Feb 19, 2025

🐰 Bencher Report

Branchivan/drop-unnecessary-release-build
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.93
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.89
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.59
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.07
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
15.05
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.94
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
991.81
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.78
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
85.41
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
222.93
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
429.38
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
677.45
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116.85
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.67
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46.11
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
61.16
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.78
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94.80
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
19.20
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
116.03
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.65
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.42
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.84
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.36
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.30
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.92
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.10
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.76
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.68
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22.35
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30.95
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.69
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.32
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.98
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
72.58
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
51.48
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
137.20
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.99
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.59
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.93
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
87.96
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.45
🐰 View full continuous benchmarking report in Bencher

When running uniffi-bindgen, we rely on the library that was just built
for the purpose of linking uniffi-bindgen.
@istankovic istankovic force-pushed the ivan/drop-unnecessary-release-build branch from 50b8fc3 to 84f4230 Compare February 19, 2025 16:15
@istankovic istankovic marked this pull request as ready for review February 19, 2025 16:16
@istankovic istankovic requested a review from a team as a code owner February 19, 2025 16:16
@istankovic istankovic merged commit 84f4230 into main Feb 20, 2025
37 checks passed
@istankovic istankovic deleted the ivan/drop-unnecessary-release-build branch February 20, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants