chore(backup): add encrypted stream [WPB-10575] #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap/feature
vitorhugods
force-pushed
the
backup/chore/add-encrypted-stream
branch
from
de9f33f to
45ef225
Compare
Test Results3 337 tests 3 230 ✅ 5m 33s ⏱️ Results for commit 03d563a. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 3230 Passed, 107 Skipped, 37.4s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic/multiplatform-backup #3154 +/- ##
============================================================
Coverage ? 54.03%
============================================================
Files ? 1246
Lines ? 36152
Branches ? 3656
============================================================
Hits ? 19533
Misses ? 15208
Partials ? 1411 Continue to review full report in Codecov by Sentry.
|
vitorhugods
requested review from
m-zagorski,
yamilmedina,
Garzas,
ohassine,
saleniuk and
sergeibakhtiarov
Garzas
reviewed
Dec 10, 2024
backup/src/commonTest/kotlin/com/wire/backup/encryption/XChaChaPoly1305EncryptedStreamTest.kt
Outdated
Show resolved
Hide resolved
|
6 tasks
Garzas
approved these changes
Dec 10, 2024
m-zagorski
approved these changes
Dec 10, 2024
vitorhugods
added a commit
that referenced
this pull request
Jan 31, 2025
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
* chore: create backup module (#3117) This commit introduces a new cross-platform backup module to the project with support for iOS, Web, and Android. Additionally, it enables JavaScript multiplatform support in existing `kalium/network-model` and `kalium/data` projects. * chore: create backup protobuf models (#3116) * feat: add initial crossplatform backup serialization [WPB-10575] (#3121) * feat: support other message types [WPB-10575] (#3122) Co-authored-by: Yamil Medina <[email protected]> * refactor(backup): make visibility modifier mandatory (#3153) * chore(backup): add encrypted stream [WPB-10575] (#3154) * chore(backup): read and write the backup header (#3159) * feat(backup): support export and import of backups on Web, iOS and Android [WPB-10575] (#3228) * refactor(backup): enhance error handling and test coverage (#3248) Refactored the backup import process to improve error handling by introducing more granular failure types and modularized the logic for decrypting and unzipping archives. Added comprehensive test coverage, including tests for edge cases in decryption, parsing, and unzipping. * chore(backup): improve backup export error handling and result encapsulation (#3257) Introduced `BackupExportResult` and `ExportResult` to encapsulate and represent export operation outcomes, including success and specific failure types (`IOError`, `ZipError`). Refactored relevant methods to use these types, added coroutine support annotations, and implemented error handling for zipping and I/O operations. Added unit tests to ensure correct error handling behavior. * feat(backup): support file peeking [WPB-10575] (#3261) Introduced `peekBackup` and related methods to retrieve backup metadata such as version, encryption status, and original creator. Also added unit tests to validate behavior for various cases, including unsupported versions and mismatched user IDs. * feat(backup): paginate different types of content (#3268) Consolidated handling of paginated backup data into the new `BackupPage` concept to improve clarity and support pagination for users, conversations, and messages during import. Added tests to validate the refactored `BackupImportPager`. * docs(backup): add multiplatform sample implementations and documentation (#3269) Introduced examples showcasing `MPBackupImporter` and `MPBackupExporter` usage for different platforms. Updated documentation, README, and build configurations to support multiplatform samples, including JS and non-JS targets. --------- Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Backups should be encrypted. We need to add support for this in the multiplatform library
Solutions
Rely on libsodium and the Kotlin Multiplatform bindings for it.
We can use libsodium's Secret Stream, which allows us to split encrypted messages in chunks, so we don't need to load the whole backup into memory.
This PR adds a wrapper around it, that uses Okio's Sink/Source to read/write data in streams.
On a future PR, I'll add the code that will actually call this, with data being backed up, etc.
This was originally implemented within
:cryptography, but was only used for BackUps and the code could use a bit of refactoring.Maybe in the future it can be in its own
:secret-streammodule.Dependencies
Needs releases with:
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.