Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send and receive in-call reactions [#WPB-14254] #3190

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

sergeibakhtiarov
Copy link
Contributor

@sergeibakhtiarov sergeibakhtiarov commented Dec 19, 2024

StoryWPB-14254 [Android] In-Call Reactions

https://wearezeta.atlassian.net/browse/WPB-14254

What's new in this PR?

Support for new In-call reaction messages.

  • Handling new type of message content
  • Repository and use case for observing incoming reactions
  • Use case for sending in-call reactions

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results

3 360 tests  +5   3 253 ✅ +5   5m 20s ⏱️ +19s
  576 suites +2     107 💤 ±0 
  576 files   +2       0 ❌ ±0 

Results for commit d168aa2. ± Comparison against base commit bb9bd8f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

🐰 Bencher Report

Branchfeat/in-call-reactions
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
685,984.84
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
535,959,189.29
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,369,145,432.96
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,837,051.46
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 19, 2024

Datadog Report

Branch report: feat/in-call-reactions
Commit report: 0b4a602
Test service: kalium-jvm

✅ 0 Failed, 3253 Passed, 107 Skipped, 59.09s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 56.41026% with 34 lines in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (bb9bd8f) to head (d168aa2).

Files with missing lines Patch % Lines
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 7 Missing ⚠️
...re/kalium/logic/data/message/ProtoContentMapper.kt 68.75% 3 Missing and 2 partials ⚠️
...re/kalium/logic/data/call/InCallReactionMessage.kt 0.00% 4 Missing ⚠️
...tlin/com/wire/kalium/logic/data/message/Message.kt 0.00% 3 Missing ⚠️
...m/wire/kalium/logic/data/message/MessageContent.kt 0.00% 3 Missing ⚠️
...kalium/logic/data/message/PersistMessageUseCase.kt 0.00% 3 Missing ⚠️
...ture/call/usecase/ObserveInCallReactionsUseCase.kt 0.00% 3 Missing ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% 2 Missing ⚠️
...kalium/logic/data/message/MessageContentLogging.kt 0.00% 1 Missing ⚠️
...eature/incallreaction/SendInCallReactionUseCase.kt 95.65% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3190      +/-   ##
===========================================
+ Coverage    54.10%   54.11%   +0.01%     
===========================================
  Files         1256     1260       +4     
  Lines        36661    36730      +69     
  Branches      3727     3733       +6     
===========================================
+ Hits         19836    19878      +42     
- Misses       15385    15414      +29     
+ Partials      1440     1438       -2     
Files with missing lines Coverage Δ
...alium/logic/data/call/InCallReactionsRepository.kt 100.00% <100.00%> (ø)
...kalium/logic/data/message/MessageContentLogging.kt 0.00% <0.00%> (ø)
...eature/incallreaction/SendInCallReactionUseCase.kt 95.65% <95.65%> (ø)
.../feature/message/PersistMigratedMessagesUseCase.kt 36.88% <0.00%> (-0.31%) ⬇️
.../conversation/message/ApplicationMessageHandler.kt 39.10% <83.33%> (+3.43%) ⬆️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)
...tlin/com/wire/kalium/logic/data/message/Message.kt 0.00% <0.00%> (ø)
...m/wire/kalium/logic/data/message/MessageContent.kt 0.00% <0.00%> (ø)
...kalium/logic/data/message/PersistMessageUseCase.kt 17.69% <0.00%> (-0.28%) ⬇️
...ture/call/usecase/ObserveInCallReactionsUseCase.kt 0.00% <0.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9bd8f...d168aa2. Read the comment docs.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well done 🚀🚀

@sergeibakhtiarov sergeibakhtiarov added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 10364c3 Dec 20, 2024
23 checks passed
@sergeibakhtiarov sergeibakhtiarov deleted the feat/in-call-reactions branch December 20, 2024 12:16
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 🚨 Potential breaking changes 👕 size: XL type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants