-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignored connection stays in conversations list [#WPB-WPB-15212] #3231
Conversation
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepository.kt
Outdated
Show resolved
Hide resolved
|
Branch | fix/hide-ignored-connection |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
CLI flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 678.94 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 341,835.55 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,345,297.78 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,890.17 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3231 +/- ##
===========================================
- Coverage 54.52% 54.46% -0.07%
===========================================
Files 1265 1268 +3
Lines 36890 36929 +39
Branches 3742 3744 +2
===========================================
- Hits 20115 20112 -3
- Misses 15362 15404 +42
Partials 1413 1413
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3287 Passed, 108 Skipped, 1m 3.95s Total Time |
d8c7c5a
to
24fd2fe
Compare
|
https://wearezeta.atlassian.net/browse/WPB-15212
What's new in this PR?
Issues
Ignored connection stays in the conversation list until app restart.
Causes (Optional)
Connection status (PENDING) is not updated to IGNORED.
Solutions
Update connection status when ignore operation succeed.