Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade upload artifact deprecation notice will start failing in feb (WPB-8645) #3243

Closed
wants to merge 2 commits into from

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 23, 2025

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Deprecation in form of failure, starting Jan 30th

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Causes (Optional)

One Workflow still using v3

Solutions

update it


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jan 23, 2025
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jan 23, 2025
@yamilmedina yamilmedina changed the title chore: upgrade upload artifact deprecation notice until 30 jan or failure (WPB-8645) ci: upgrade upload artifact deprecation notice will start failing in feb (WPB-8645) Jan 23, 2025
@yamilmedina yamilmedina deleted the ci/upgrade-upload-artifat branch January 23, 2025 16:11
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.43%. Comparing base (7456f22) to head (4a09122).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3243      +/-   ##
===========================================
- Coverage    54.43%   54.43%   -0.01%     
===========================================
  Files         1271     1271              
  Lines        37062    37062              
  Branches      3764     3764              
===========================================
- Hits         20176    20173       -3     
- Misses       15466    15469       +3     
  Partials      1420     1420              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7456f22...4a09122. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants