Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cc to 3.1.0 [WPB-16041] #3292

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 13, 2025

TaskWPB-16041 [Android] Bump CoreCrypto to 3.1.0


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

bump cc to 3.1.0

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel
Copy link
Member

typfel commented Feb 13, 2025

@MohamadJaara make sure that you ignore the new error.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Test Results

3 360 tests  ±0   3 252 ✅ ±0   5m 31s ⏱️ -25s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit dd6b33e. ± Comparison against base commit 23aafad.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 28 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (23aafad) to head (dd6b33e).

Files with missing lines Patch % Lines
...r/conversation/message/MLSMessageFailureHandler.kt 15.62% 0 Missing and 27 partials ⚠️
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3292      +/-   ##
=====================================================
- Coverage              54.53%   54.51%   -0.02%     
=====================================================
  Files                   1252     1252              
  Lines                  36631    36652      +21     
  Branches                3712     3734      +22     
=====================================================
+ Hits                   19975    19980       +5     
+ Misses                 15254    15252       -2     
- Partials                1402     1420      +18     
Files with missing lines Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 32.12% <50.00%> (-0.41%) ⬇️
...r/conversation/message/MLSMessageFailureHandler.kt 24.32% <15.62%> (-9.01%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23aafad...dd6b33e. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 13, 2025

Datadog Report

Branch report: chore/bump-cc-to-3.1
Commit report: 4abfa18
Test service: kalium-jvm

✅ 0 Failed, 3252 Passed, 108 Skipped, 1m 2.78s Total Time

@MohamadJaara MohamadJaara changed the title chore: bump cc to 3.1.0 chore: bump cc to 3.1.0 [WPB-16041] Feb 13, 2025
@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 14, 2025
Merged via the queue into release/candidate with commit 040b38c Feb 14, 2025
20 checks passed
@MohamadJaara MohamadJaara deleted the chore/bump-cc-to-3.1 branch February 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants