Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error handling simplified, not needed case (WPB-15520) #3295

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 17, 2025

TaskWPB-15520 [Android] - Implement error handling for initial screens


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Remove case not needed for UI handling, since we already have a generic case that can transform from CoreFailure.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Test Results

3 441 tests   3 333 ✅  5m 57s ⏱️
  591 suites    108 💤
  591 files        0 ❌

Results for commit b87d852.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (epic/new-sso-login-flow@acf70f0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...com/wire/kalium/logic/data/auth/LoginDomainPath.kt 60.00% 4 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             epic/new-sso-login-flow    #3295   +/-   ##
==========================================================
  Coverage                           ?   53.97%           
==========================================================
  Files                              ?     1324           
  Lines                              ?    37640           
  Branches                           ?     3788           
==========================================================
  Hits                               ?    20318           
  Misses                             ?    15905           
  Partials                           ?     1417           
Files with missing lines Coverage Δ
...logic/feature/auth/GetLoginFlowForDomainUseCase.kt 97.36% <100.00%> (ø)
...com/wire/kalium/logic/data/auth/LoginDomainPath.kt 63.63% <60.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf70f0...b87d852. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 17, 2025

Datadog Report

Branch report: feat/newlogin-consumepath-usecase
Commit report: 6ec3e99
Test service: kalium-jvm

✅ 0 Failed, 3333 Passed, 108 Skipped, 1m 2.86s Total Time

@yamilmedina yamilmedina merged commit 6761c3a into epic/new-sso-login-flow Feb 18, 2025
20 checks passed
@yamilmedina yamilmedina deleted the feat/newlogin-consumepath-usecase branch February 18, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants