Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump avs version to 10.0.8 (WPB-15553) #3299

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 19, 2025

BugWPB-15553 [Android] Incoming call notification displayed forever when call accepted on another client


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In some edge cases, Incoming call notification stays forever when call accepted on another client

Causes (Optional)

In AVS, incoming handler stored as pending event directly instead of after mediamanager execution

Solutions

Updated AVS

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Test Results

3 520 tests  ±0   3 412 ✅ ±0   6m 9s ⏱️ -20s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit 1721d02. ± Comparison against base commit 7c462ea.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.68%. Comparing base (7c462ea) to head (1721d02).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3299      +/-   ##
===========================================
- Coverage    50.68%   50.68%   -0.01%     
===========================================
  Files         1611     1611              
  Lines        58145    58145              
  Branches      5246     5246              
===========================================
- Hits         29473    29472       -1     
  Misses       26645    26645              
- Partials      2027     2028       +1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c462ea...1721d02. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: update-avs-10.0.8
Commit report: ce09059
Test service: kalium-jvm

✅ 0 Failed, 3412 Passed, 108 Skipped, 1m 2.65s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants