Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wipe conversation after member leave event [WPB-16204] 🍒 #3302

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 20, 2025

TaskWPB-16204 [Android] First message missing after leaving and being added to MLS group

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When the user is logged in to two clients, web and android, is added to a conversation, then leaves from web and then is added again then:

  • when web client sends first message android client will not receive this message and will show recovery system message

Causes (Optional)

First message after rejoining to conversation is not visible to other client

Solutions

  • wipe mls conversation if Member remove event contains self user
  • fixed issue for triggering requesting twice to remove self user from conversation

Copy link
Contributor Author

github-actions bot commented Feb 21, 2025

Test Results

3 522 tests  +2   3 414 ✅ +2   5m 58s ⏱️ -31s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit ceaff59. ± Comparison against base commit 7c462ea.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.69%. Comparing base (7c462ea) to head (ceaff59).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3302   +/-   ##
========================================
  Coverage    50.68%   50.69%           
========================================
  Files         1611     1611           
  Lines        58145    58163   +18     
  Branches      5246     5249    +3     
========================================
+ Hits         29473    29487   +14     
- Misses       26645    26648    +3     
- Partials      2027     2028    +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c462ea...ceaff59. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/wipe-conversation-after-client-left-cherry-pick
Commit report: 27a1ccc
Test service: kalium-jvm

✅ 0 Failed, 3414 Passed, 108 Skipped, 1m 0.97s Total Time

@Garzas Garzas added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit 56a663f Feb 21, 2025
22 checks passed
@Garzas Garzas deleted the fix/wipe-conversation-after-client-left-cherry-pick branch February 21, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants