-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wipe conversation after member leave event [WPB-16204] 🍒 #3302
fix: wipe conversation after member leave event [WPB-16204] 🍒 #3302
Conversation
|
|
Branch | fix/wipe-conversation-after-client-left-cherry-pick |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 692.58 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 601,227.63 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,344,468.61 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 26,718.76 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3302 +/- ##
========================================
Coverage 50.68% 50.69%
========================================
Files 1611 1611
Lines 58145 58163 +18
Branches 5246 5249 +3
========================================
+ Hits 29473 29487 +14
- Misses 26645 26648 +3
- Partials 2027 2028 +1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3414 Passed, 108 Skipped, 1m 0.97s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When the user is logged in to two clients, web and android, is added to a conversation, then leaves from web and then is added again then:
Causes (Optional)
First message after rejoining to conversation is not visible to other client
Solutions