Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Oct 17, 2025

BugWPB-20906 [Android] Uploading a big asset and sending the app to the background cancels the upload and sending failing

https://wearezeta.atlassian.net/browse/WPB-20906

What's new in this PR?

Issues

Observing upload state for background uploads support

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Test Results

0 tests   - 3 962   0 ✅  - 3 851   0s ⏱️ - 5m 9s
0 suites  -   676   0 💤  -   111 
0 files    -   676   0 ❌ ±    0 

Results for commit 100ac86. ± Comparison against base commit d069c75.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.46%. Comparing base (032f6fb) to head (100ac86).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ic/feature/asset/ObserveAssetUploadStateUseCase.kt 0.00% 18 Missing ⚠️
...ium/cells/data/MessageAttachmentDraftDataSource.kt 0.00% 5 Missing ⚠️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 0.00% 5 Missing ⚠️
...ic/feature/asset/ScheduleNewAssetMessageUseCase.kt 20.00% 3 Missing and 1 partial ⚠️
...ire/kalium/logic/data/message/MessageRepository.kt 0.00% 3 Missing ⚠️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 2 Missing ⚠️
...messageattachment/MessageAttachmentDraftDaoImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3669      +/-   ##
===========================================
- Coverage    57.55%   57.46%   -0.09%     
===========================================
  Files         1778     1781       +3     
  Lines        65332    65490     +158     
  Branches      5748     5770      +22     
===========================================
+ Hits         37602    37637      +35     
- Misses       25304    25419     +115     
- Partials      2426     2434       +8     
Files with missing lines Coverage Δ
...m/cells/domain/MessageAttachmentDraftRepository.kt 100.00% <ø> (ø)
...om/wire/kalium/logic/data/asset/AssetRepository.kt 90.60% <100.00%> (ø)
.../wire/kalium/persistence/dao/message/MessageDAO.kt 91.66% <ø> (ø)
...messageattachment/MessageAttachmentDraftDaoImpl.kt 0.00% <0.00%> (ø)
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)
...ire/kalium/logic/data/message/MessageRepository.kt 51.36% <0.00%> (-0.54%) ⬇️
...ic/feature/asset/ScheduleNewAssetMessageUseCase.kt 87.69% <20.00%> (-1.79%) ⬇️
...ium/cells/data/MessageAttachmentDraftDataSource.kt 0.00% <0.00%> (ø)
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 72.80% <0.00%> (-1.09%) ⬇️
...ic/feature/asset/ObserveAssetUploadStateUseCase.kt 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032f6fb...100ac86. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

🐰 Bencher Report

Branchfeat/background-upload
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
701.79 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
616,117.58 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,510,620.14 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
29,510.60 µs
🐰 View full continuous benchmarking report in Bencher

@sbakhtiarov sbakhtiarov force-pushed the feat/background-upload branch from 97cf37b to 100ac86 Compare October 22, 2025 15:19
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants