fix: InCallReaction background in dark mode #WPB-15550 #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap/feature
|
|
Built wire-android-staging-compat-pr-3835.apk is available for download |
|
Built wire-android-dev-debug-pr-3835.apk is available for download |
ohassine
approved these changes
Jan 27, 2025
Garzas
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When the user has the app set to dark mode, the incall reactions are shown in light mode once a reaction is sent.
We should also show them in dark mode.
Causes (Optional)
emojiBackgroundColorin dark color scheme was wrong.Solutions
set a correct color to
emojiBackgroundColorAttachments (Optional)