Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Calling.call_quality segmentations (WPB-15086) #3857

Merged
merged 17 commits into from
Feb 18, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 4, 2025

EpicWPB-15086 Fixing the cross-platform inconsistencies of the calling.call_quality_review event


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

  • We need to add some new segmentations to calling.call_quality_review event.
  • I also refactored a bit the code by moving survey related stuffs to CallFeedbackViewModel

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and Garzas and removed request for a team February 4, 2025 13:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (f74b244) to head (ddba653).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/CallFeedbackViewModel.kt 87.83% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3857      +/-   ##
===========================================
+ Coverage    45.32%   45.48%   +0.16%     
===========================================
  Files          491      492       +1     
  Lines        17026    17083      +57     
  Branches      2852     2855       +3     
===========================================
+ Hits          7717     7771      +54     
+ Misses        8518     8517       -1     
- Partials       791      795       +4     
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 56.57% <100.00%> (-0.82%) ⬇️
...otlin/com/wire/android/ui/CallFeedbackViewModel.kt 87.83% <87.83%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74b244...ddba653. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Built wire-android-staging-compat-pr-3857.apk is available for download

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Built wire-android-dev-debug-pr-3857.apk is available for download

@ohassine ohassine requested a review from borichellow February 12, 2025 16:00
Copy link
Contributor

Built wire-android-staging-compat-pr-3857.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3857.apk is available for download

…ty_review-segmentations

# Conflicts:
#	core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
@ohassine ohassine enabled auto-merge February 18, 2025 17:15
@ohassine ohassine added this pull request to the merge queue Feb 18, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3857.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3857.apk is available for download

Merged via the queue into develop with commit a42e7f5 Feb 18, 2025
12 of 13 checks passed
@ohassine ohassine deleted the calling.call_quality_review-segmentations branch February 18, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants