Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FileSharing menu - no gaps #WPB-15276 #3869

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Feb 7, 2025

BugWPB-15276 [Android] File sharing menu should not have a gaps

What's new in this PR?

Issues

  • There should be no gap between the additional options menu and the text input field or on the left and right side of the menu.
  • Send message btn should not be visible when the keyboard is closed and there is no text to send. (this is out of the scope of task, but i found that regression, so just fixed it)

Attachments (Optional)

Screenshot 2025-02-07 at 17 47 57

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (9522bbb) to head (a68fae7).

Files with missing lines Patch % Lines
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3869      +/-   ##
===========================================
- Coverage    45.45%   45.45%   -0.01%     
===========================================
  Files          491      491              
  Lines        17011    17012       +1     
  Branches      2846     2846              
===========================================
  Hits          7733     7733              
- Misses        8491     8492       +1     
  Partials       787      787              
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9522bbb...a68fae7. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Built wire-android-staging-compat-pr-3869.apk is available for download

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Built wire-android-dev-debug-pr-3869.apk is available for download

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Built wire-android-staging-compat-pr-3869.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3869.apk is available for download

@borichellow borichellow added this pull request to the merge queue Feb 10, 2025
Merged via the queue into develop with commit 8a13c77 Feb 10, 2025
11 of 12 checks passed
@borichellow borichellow deleted the fix/file_sharing_menu_no_gaps branch February 10, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants