refactor: generate notification user contact join - WPB-11660 #2383
+345
−64
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2025 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| import UserNotifications | ||
|
|
||
| struct UserConnectionNotificationBuilder: NotificationBuilder { | ||
|
|
||
| enum ConnectionStatus { | ||
| case joined | ||
|
There was a problem hiding this comment. I guess this is for the case where someone in your address book creates an account on Wire. But I don't think we get this event anymore, in which case I don't think we need to support this notification. Best to check with BE. |
||
| case pending | ||
| case accepted | ||
| } | ||
|
|
||
| struct Context { | ||
| let connectionStatus: ConnectionStatus | ||
| let username: String | ||
| } | ||
|
|
||
| private let context: Context | ||
|
|
||
| init( | ||
| connectionStatus: ConnectionStatus, | ||
| username: String | ||
| ) { | ||
| self.context = Context( | ||
| connectionStatus: connectionStatus, | ||
| username: username | ||
| ) | ||
| } | ||
|
|
||
| func shouldBuildNotification() async -> Bool { | ||
| true | ||
| } | ||
|
|
||
| func buildContent() async -> UNMutableNotificationContent { | ||
| switch context.connectionStatus { | ||
| case .joined: | ||
| buildUserJoinNotification() | ||
| case .pending: | ||
| // TODO: [WPB-11659] To implement | ||
| UNMutableNotificationContent() | ||
| case .accepted: | ||
| // TODO: [WPB-11659] To implement | ||
| UNMutableNotificationContent() | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Build notifications | ||
|
|
||
| private func buildUserJoinNotification() -> UNMutableNotificationContent { | ||
| let content = UNMutableNotificationContent() | ||
|
|
||
| let body = NotificationBody.userConnection( | ||
| .userJoined(username: context.username) | ||
| ) | ||
|
|
||
| content.body = body.make() | ||
| content.categoryIdentifier = makeCategory() | ||
| content.sound = makeSound() | ||
|
|
||
| return content | ||
| } | ||
|
|
||
| // MARK: - Helpers | ||
|
|
||
| private func makeSound(type: NotificationSound = .default) -> UNNotificationSound { | ||
| let notificationSoundName = UNNotificationSoundName(type.rawValue) | ||
| return UNNotificationSound(named: notificationSoundName) | ||
| } | ||
|
|
||
| private func makeCategory() -> String { | ||
| switch context.connectionStatus { | ||
| case .joined: | ||
| NotificationCategory.nonActionable.rawValue | ||
| case .pending, .accepted: | ||
| // TODO: [WPB-11659] To implement | ||
| "" | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2025 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| import UserNotifications | ||
| import WireAPI | ||
| import WireDataModel | ||
|
|
||
| struct UserNotificationBuilder: NotificationBuilder { | ||
|
|
||
| private let event: UserEvent | ||
|
|
||
| init( | ||
| event: UserEvent | ||
| ) { | ||
| self.event = event | ||
| } | ||
|
|
||
| func shouldBuildNotification() async -> Bool { | ||
| true | ||
| } | ||
|
|
||
| func buildContent() async -> UNMutableNotificationContent { | ||
| let builder: NotificationBuilder | ||
|
|
||
| switch event { | ||
| case let .connection(userConnectionEvent): | ||
| let isPending = userConnectionEvent.connection.status == .pending | ||
|
|
||
| builder = UserConnectionNotificationBuilder( | ||
| connectionStatus: isPending ? .pending : .accepted, | ||
| username: userConnectionEvent.userName | ||
| ) | ||
|
|
||
| case let .contactJoin(userContactJoinEvent): | ||
|
|
||
| builder = UserConnectionNotificationBuilder( | ||
| connectionStatus: .joined, | ||
| username: userContactJoinEvent.name | ||
| ) | ||
|
|
||
| default: | ||
| return UNMutableNotificationContent() | ||
| } | ||
|
|
||
| guard await builder.shouldBuildNotification() else { | ||
| return UNMutableNotificationContent() | ||
| } | ||
|
|
||
| return await builder.buildContent() | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by the naming, what is the relevance of "system message"?