chore: convert to folder Wire-iOS - WPB-16244 #2421
+881
−14,664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caldrian
changed the title
echoes-hq
bot
added
the
echoes: technical-roadmap
netbe
force-pushed
the
chore/convert-to-folder-wire-ios
branch
from
0d66ca5 to
754a668
Compare
netbe
commented
Feb 21, 2025
| @@ -14,111 +14,111 @@ | |||
|
|
|||
| files: [ | |||
| { | |||
| "source" : "/wire-ios/Wire-iOS/Resources/Base.lproj/Localizable.strings", | |||
| "source" : "/wire-ios/Wire-iOS/Resources/Localization/Base.lproj/Localizable.strings", | |||
There was a problem hiding this comment.
I had to move the localizable inside a folder, hence the change
netbe
commented
Feb 21, 2025
| <key>NSExtensionPointIdentifier</key> | ||
| <string>com.apple.share-services</string> | ||
| <key>NSExtensionPrincipalClass</key> | ||
| <string>$(PRODUCT_MODULE_NAME).ShareExtensionViewController</string> |
There was a problem hiding this comment.
this replaces the MainInterface storyboard
netbe
changed the title
Test Results 1 files 2 suites 1m 57s ⏱️ Results for commit 9f2e0b0. |
Datadog ReportBranch report: ✅ 0 Failed, 1687 Passed, 26 Skipped, 1m 57.66s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Only a supporting Files group remains for Wire-iOS
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: