Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert Wire Request Strategy project to use folders - WPB-15572 #2428

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 24, 2025

StoryWPB-15572 [iOS] Convert groups to folders

Issue

Fixes file locations, removes unused files, converts groups to folders in Wire Request Strategy.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Jan 24, 2025
@@ -1,256 +0,0 @@
//
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need a script for the crowdin action to not generate unsupported languages

Copy link
Collaborator

@netbe netbe Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are not used at all, so do we really need anything here? ah right there are used in LocalNotificationType+Localization.swift

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 99a38e7.

♻️ This comment has been updated with latest results.

@netbe netbe self-requested a review February 19, 2025 08:07
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as the other PR update the MARKETING_VERSION with 276.0.2

…nup-wire-request-strategy-WPB-15572

# Conflicts:
#	wire-ios-request-strategy/WireRequestStrategy.xcodeproj/project.pbxproj
@caldrian caldrian added the WIP label Feb 19, 2025
@caldrian caldrian marked this pull request as draft February 19, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants