Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate new initial sync - WPB-10801 #2527

Merged
merged 50 commits into from
Feb 21, 2025

Conversation

johnxnguyen
Copy link
Collaborator

@johnxnguyen johnxnguyen commented Feb 12, 2025

TaskWPB-10801 [iOS] Integrate new slow sync

Issue

In this PR we integrate the new initial sync by:

  • initializing and injecting SyncAgent into the ZMUserSession
  • replace calls to the SyncStatus with calls to SyncAgent

If the developer flag newInitialSync is off (the default), then the SyncAgent will execute legacy code paths via the SyncStatus. If it is on, it will run the new initial sync, then continue with the legacy incremental sync.

Integrating the new incremental sync will follow in a subsequent PR.

Testing

To check the legacy code paths are still in tact, install the app fresh and log in and use the app as normal. To test the new code paths, enabled the flag via the developer menu.

Issues to look for include infinite sync, getting stuck when logging in or registering a client (including deleting a client).


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe self-requested a review February 12, 2025 15:04
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, adding some thoughts and concerns about processing buffered events in legacy

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@johnxnguyen johnxnguyen marked this pull request as ready for review February 12, 2025 16:45
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Test Results

    5 files      6 suites   5m 33s ⏱️
4 728 tests 4 698 ✅ 28 💤 2 ❌
4 738 runs  4 710 ✅ 28 💤 0 ❌

For more details on these failures, see this check.

Results for commit 7fefd5b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 12, 2025

Datadog Report

Branch report: refactor/integrate-sync-agent-wpb-10801
Commit report: d3e339c
Test service: wire-ios-mono

✅ 0 Failed, 4485 Passed, 28 Skipped, 2m 1.74s Total Time

@johnxnguyen johnxnguyen changed the base branch from release/cycle-3.118 to develop February 14, 2025 08:04
@johnxnguyen johnxnguyen changed the base branch from develop to release/cycle-3.118 February 14, 2025 08:04
…wireapp/wire-ios into refactor/integrate-sync-agent-wpb-10801
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes with the Components, I left some more comments just ping me when I need to look again

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just adding a last point

@samwyndham
Copy link
Contributor

Un-assigning myself as this PR is already approved. Feel free to add be back

@samwyndham samwyndham removed their request for review February 20, 2025 14:34
@johnxnguyen johnxnguyen added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@johnxnguyen johnxnguyen added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit cbf923c Feb 21, 2025
14 checks passed
@johnxnguyen johnxnguyen deleted the refactor/integrate-sync-agent-wpb-10801 branch February 21, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants