-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: integrate new initial sync - WPB-10801 #2527
refactor: integrate new initial sync - WPB-10801 #2527
Conversation
wire-ios-sync-engine/Source/SessionManager/SessionFactories.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/Synchronization/ApplicationStatusDirectory.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/Providers/InitialSyncBuilder.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, adding some thoughts and concerns about processing buffered events in legacy
wire-ios-sync-engine/Source/SessionManager/SessionManager.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
.../Wire-iOS/Sources/Developer/DeveloperTools/DebugActions/DeveloperDebugActionsViewModel.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;)
Test Results 5 files 6 suites 5m 33s ⏱️ For more details on these failures, see this check. Results for commit 7fefd5b. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 4485 Passed, 28 Skipped, 2m 1.74s Total Time |
…wireapp/wire-ios into refactor/integrate-sync-agent-wpb-10801
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes with the Components, I left some more comments just ping me when I need to look again
WireDomain/Sources/WireDomain/Providers/InitialSyncBuilderProtocol.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
…wireapp/wire-ios into refactor/integrate-sync-agent-wpb-10801
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, just adding a last point
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
Outdated
Show resolved
Hide resolved
Un-assigning myself as this PR is already approved. Feel free to add be back |
Issue
In this PR we integrate the new initial sync by:
SyncAgent
into theZMUserSession
SyncStatus
with calls toSyncAgent
If the developer flag
newInitialSync
is off (the default), then theSyncAgent
will execute legacy code paths via theSyncStatus
. If it is on, it will run the new initial sync, then continue with the legacy incremental sync.Integrating the new incremental sync will follow in a subsequent PR.
Testing
To check the legacy code paths are still in tact, install the app fresh and log in and use the app as normal. To test the new code paths, enabled the flag via the developer menu.
Issues to look for include infinite sync, getting stuck when logging in or registering a client (including deleting a client).
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: