fix: crash on conversation content - WPB-15979 #2554
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 2 suites 2m 2s ⏱️ Results for commit 582ee7f. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1687 Passed, 26 Skipped, 2m 1.84s Total Time |
netbe
requested review from
a team,
samwyndham,
johnxnguyen and
jullianm
and removed request for
a team
samwyndham
reviewed
Feb 18, 2025
johnxnguyen
reviewed
Feb 19, 2025
There was a problem hiding this comment.
looks good but I want to see the answer to @samwyndham 's question.
...os/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationTableViewDataSource.swift
Outdated
Show resolved
Hide resolved
jullianm
approved these changes
Feb 19, 2025
|
@samwyndham I changed the implementation to refetch when resuming to foreground, so no updates are missed |
johnxnguyen
approved these changes
Feb 21, 2025
samwyndham
approved these changes
Feb 21, 2025
| do { | ||
| try fetchController?.performFetch() | ||
| tableView.reloadData() | ||
| tableView.setContentOffset(contentOffset, animated: false) |
There was a problem hiding this comment.
thought: I'm surprised that this is needed - I assume you saw an issue with the content offset changing when calling reload data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In the crash report associated to the ticket, we can see that the app is killed by the system while fetching messages of the conversation in CoreData while in background.
It's not directly clear if the exhaustion of resources we get is caused by just fetching a lot of messages or processing in another thread messages.
Solution
In case of the first one, we could remove the observation of changes in the current conversation when moving to background.
Testing