fix: infinite loop and code optimization - WPB-16115 #2563
+111
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbe
reviewed
Feb 19, 2025
|
Converting it back to draft, I've tested again after merging some new work done in 3.118 and now it fails again.. @netbe this won't make it for play test I need to see what's wrong |
netbe
reviewed
Feb 20, 2025
| @@ -97,7 +97,7 @@ actor EventProcessor: UpdateEventProcessor { | |||
|
|
|||
| guard !DeveloperFlag.ignoreIncomingEvents.isOn else { return } | |||
|
|
|||
| let publicKeys = try? self.earService.fetchPublicKeys() | |||
| let publicKeys = try? await self.earService.fetchPublicKeys() | |||
There was a problem hiding this comment.
question: something changed here?
There was a problem hiding this comment.
we were not using await: simple compilation warning but this will be an error in Swift 6
jullianm
changed the title
Test Results 4 files 4 suites 8m 17s ⏱️ For more details on these failures, see this check. Results for commit ef71844. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 4764 Passed, 2 Skipped, 4m 41.74s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPB-16115
Issue
Context: When logging out from an MLS account, the account is not deleted because the dispatchGroup notify method still has ongoing operations, specifically
commitPendingProposalsrelated work which fills in the dispatch group abnormally. Also we have sometimes an infinite loop when trying to recover after failing to commit pending proposals.Causes: First reason is that some pending proposals are planned for the future and we do a
Task.sleepto wait for that date to commit the proposal, which blocks the groups.Another reason is that when we retry on a commit failure, we perform a quick sync which (when finishing) triggers the commit pending proposals method again which fills the group again and so on which ends up in a loop.
Proposed solutions: first, use dedicated Tasks to not block the group so we can leave it in a reasonable time and second, when we try to recover from a commit error and performing a quick sync, do not try to commit pending proposals again as we're already in the process of recovering these commits.
This PR is tightly related to this PR which solely focused on fixing the logout issue while this current PR introduces various code optimization related to the logic of committing pending proposals as well as fixing the loop.
Testing
No infinite syncing occurs on MLS account
Checklist
[WPB-XXX].