feat: port BrowserViewController - WPB-15927 #2566
Open
+189
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaterinaWire
commented
Feb 19, 2025
| @@ -54,7 +54,8 @@ class DetermineAuthMethodComponent: Component<DetermineAuthMethodComponentDepend | |||
| @MainActor var determineAuthMethodView: DetermineAuthMethodView { | |||
| DetermineAuthMethodView( | |||
| viewModel: viewModel, | |||
| builder: loginViaEmailComponent | |||
| builder: loginViaEmailComponent, | |||
There was a problem hiding this comment.
Should we rename this builder?
There was a problem hiding this comment.
Do you mean, rename it to loginViaEmailBuilder? I would say yes.
Test Results34 tests 34 ✅ 6s ⏱️ Results for commit d8d1460. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 29 Passed, 0 Skipped, 6.7s Total Time |
samwyndham
approved these changes
Feb 19, 2025
...ication/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodView.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
reviewed
Feb 20, 2025
| @@ -54,7 +54,8 @@ class DetermineAuthMethodComponent: Component<DetermineAuthMethodComponentDepend | |||
| @MainActor var determineAuthMethodView: DetermineAuthMethodView { | |||
| DetermineAuthMethodView( | |||
| viewModel: viewModel, | |||
| builder: loginViaEmailComponent | |||
| builder: loginViaEmailComponent, | |||
There was a problem hiding this comment.
Do you mean, rename it to loginViaEmailBuilder? I would say yes.
WireAuthentication/Sources/WireAuthenticationUI/Views/Root/Router.swift
Outdated
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationUI/Views/Root/RootViewModel.swift
Outdated
Show resolved
Hide resolved
...ication/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodView.swift
Outdated
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationUI/Views/Root/Router.swift
Outdated
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationUI/Views/Login/LoginViaSSO/LoginViaSSOView.swift
Outdated
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationUI/Views/Login/LoginViaSSO/BrowserView.swift
Outdated
Show resolved
Hide resolved
samwyndham
approved these changes
Feb 21, 2025
...thentication/Sources/WireAuthenticationUI/Views/Login/LoginViaSSO/LoginViaSSOViewModel.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
approved these changes
Feb 21, 2025
...on/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodViewModel.swift
Outdated
Show resolved
Hide resolved
...ication/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodView.swift
Outdated
Show resolved
Hide resolved
WireAuthentication/Sources/WireAuthenticationUI/Views/Login/LoginViaSSO/LoginViaSSOView.swift
Outdated
Show resolved
Hide resolved
…eAuthMethod/DetermineAuthMethodView.swift Co-authored-by: John Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We need to display the SSO login Web page in-app as a modal view, not as a part of the navigation stack.
Solution
We are currently using
SFSafariViewController, but will probably want to use[ASWebAuthenticationSession](https://developer.apple.com/documentation/authenticationservices/aswebauthenticationsession)in the future. Switching toASWebAuthenticationSessionis not that easy, so I decided to copyBrowserViewControllerand create a ticket for the future to investigate and decide whether we need/should useASWebAuthenticationSession.Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: