-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made it a bit more extensible and reusable #149
Open
Kojotto
wants to merge
4
commits into
wix-incubator:master
Choose a base branch
from
Kojotto:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the function to the controller so that the directive can be more extensible. Now you can create your own directive that has a different template but can still use the original functions. example: .directive("treecontrolfoldering", function () { return { restrict: "A", require: "treecontrol", link: function (scope, element, attributes, ctrl) { ctrl.ensureDefault(ctrl.$scope.options, "nodeFolderType", "FolderType"); ctrl.$scope.folderTypeClass = function (node) { var t = scope.foldering.getDestinationObject(node); if (t.isFolderType) { return t.cssClass; } }; ctrl.defaultIsLeaf = function (node) { return (!node[ctrl.$scope.options.nodeChildren] || node[ctrl.$scope.options.nodeChildren].length === 0) && (!node[ctrl.$scope.options.nodeFolderType] || node[ctrl.$scope.options.nodeFolderType].length === 0); } ctrl.$scope.options.isLeaf = ctrl.defaultIsLeaf; ctrl.orderBy = "| orderBy:'Name'"; ctrl.orderByFolderType = "| orderBy:'toString()'"; var template = '<ul ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.ul, true) + '>' + '<li ng-repeat="node in node.' + ctrl.$scope.options.nodeFolderType + ' | filter:filterExpression:filterComparator ' + ctrl.orderByFolderType + '" ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.li, true) + ' class="folder-type">' + '<i class="type-icon" ng-class="folderTypeClass(node)"></i>' + '<div class="tree-label ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.label, false) + '" tree-transclude-foldertype></div>' + '</li>' + '<li ng-repeat="node in node.' + ctrl.$scope.options.nodeChildren + ' | filter:filterExpression:filterComparator ' + ctrl.orderBy + '" ng-class="headClass(node)" ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.li, true) + '>' + '<i class="tree-branch-head" ng-class="iBranchClass()" ng-click="selectNodeHead(node)"></i>' + '<i class="tree-leaf-head ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.iLeaf, false) + '"></i>' + '<div class="tree-label ' + ctrl.classIfDefined(ctrl.$scope.options.injectClasses.label, false) + '" ng-class="[selectedClass(), unselectableClass()]" ng-click="selectNodeLabel(node)" tree-transclude></div>' + '<treeitem-foldering ng-if="nodeExpanded()"></treeitem-foldering>' + '</li>' + '</ul>'; ctrl.template = ctrl.$compile(template); } } });
Removed some unnecessary bindings. you can now extend the directive, example: .directive("treecontrolfoldering", function() { return { restrict: "A", require: "treecontrolFoldering", link: function(scope, element, attributes, ctrl) { var isolateScope = element.isolateScope(); ctrl.ensureDefault(element.isolateScope().options, "nodeFolderType", "FolderType"); isolateScope.folderTypeClass = function (node) { var destinationType = scope.foldering.getDestinationObject(node); return destinationType.cssClass; }; ctrl.defaultIsLeaf = function(node) { return (!node[isolateScope.options.nodeChildren] || node[isolateScope.options.nodeChildren].length === 0) && (!node[isolateScope.options.nodeFolderType] || node[isolateScope.options.nodeFolderType].length === 0); } isolateScope.options.isLeaf = ctrl.defaultIsLeaf; ctrl.orderBy = "| orderBy:'Name'"; ctrl.orderByFolderType = "| orderBy:'toString()'"; var template = '<ul ' + ctrl.classIfDefined(isolateScope.options.injectClasses.ul, true) + '>' + '<li ng-repeat="node in node.' + isolateScope.options.nodeFolderType + ' | filter:filterExpression:filterComparator ' + ctrl.orderByFolderType + '" ' + ctrl.classIfDefined(isolateScope.options.injectClasses.li, true) + ' class="folder-type">' + '<i class="type-icon" ng-class="folderTypeClass(node)"></i>' + '<div class="tree-label ' + ctrl.classIfDefined(isolateScope.options.injectClasses.label, false) + '" tree-transclude-foldertype></div>' + '</li>' + '<li ng-repeat="node in node.' + isolateScope.options.nodeChildren + ' | filter:filterExpression:filterComparator ' + ctrl.orderBy + '" ng-class="headClass(node)" ' + ctrl.classIfDefined(isolateScope.options.injectClasses.li, true) + '>' + '<i class="tree-branch-head" ng-class="iBranchClass()" ng-click="selectNodeHead(node)"></i>' + '<i class="tree-leaf-head ' + ctrl.classIfDefined(isolateScope.options.injectClasses.iLeaf, false) + '"></i>' + '<div class="tree-label ' + ctrl.classIfDefined(isolateScope.options.injectClasses.label, false) + '" ng-class="[selectedClass(), unselectableClass()]" ng-click="selectNodeLabel(node)" tree-transclude></div>' + '<treeitem-foldering ng-if="nodeExpanded()"></treeitem-foldering>' + '</li>' + '</ul>'; ctrl.template = ctrl.recompileTemplate(template); } } }); some additional code is needed but ...
Changed the orderBy back to private as it's not needed on the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all the functions that are used inside the template to be available from the controller.
What you can do now is something like this:
.directive("treecontrolfoldering", function() {
return {
restrict: "A",
require: "treecontrolFoldering",
link: function(scope, element, attributes, ctrl) {