Docs/example fixes #3687
Open
Docs/example fixes #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd improved layout
…larity and consistency
…and maxValue props
nitzanyiz
reviewed
Apr 21, 2025
| @@ -26,7 +26,8 @@ const VALID_COMPONENTS_CATEGORIES = [ | |||
| 'incubator', | |||
| 'infra', | |||
| // non components categories | |||
| 'services' | |||
| 'services', | |||
| 'dev' // development category for components we don't want to render in our docs (used in test.api.json) | |||
There was a problem hiding this comment.
Do we want to add this to the sidebars? Perhaps only in the next version?
There was a problem hiding this comment.
How do you recommend doing it only for next?
There was a problem hiding this comment.
We can add it to
react-native-ui-lib/docuilib/sidebars.js
Lines 26 to 28 in 2015fa0
Now that I see there a huge difference between the design of the sidebars in the regular version then in the next version. In the regular version theres dividers and such.
I guess it was added here manually. we'll have to adjust the sidebars script to generate that, we need to add that to the components sidebar. I'll create a pr.
{
type: 'category',
label: 'Incubator',
collapsible: false,
items: [
{
type: 'autogenerated',
dirName: `components/infra`
}
]
},
{
type: 'category',
label: 'Infra',
collapsible: false,
items: [
{
type: 'autogenerated',
dirName: `components/infra`
}
]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve various components snippets (code examples)
Changelog
NA
Additional info