update unit tests

wjakethompson · Jan 13, 2025 · b7d666c · b7d666c
1 parent f7ac91b
commit b7d666c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/tests/testthat/test-ecpe.R b/tests/testthat/test-ecpe.R
@@ -289,11 +289,7 @@ test_that("mcmc requirements error", {
   expect_s3_class(err, "error_bad_method")
   expect_match(err$message, "`method = \"mcmc\"`")
 
-  err <- rlang::catch_cnd(add_criterion(cmds_ecpe_lcdm, "loo"))
-  expect_s3_class(err, "error_bad_method")
-  expect_match(err$message, "`method = \"mcmc\"`")
-
-  err <- rlang::catch_cnd(add_criterion(cmds_ecpe_lcdm, "waic"))
+  err <- rlang::catch_cnd(add_criterion(cmds_ecpe_lcdm))
   expect_s3_class(err, "error_bad_method")
   expect_match(err$message, "`method = \"mcmc\"`")
 })
@@ -304,11 +300,7 @@ test_that("optim requirements error", {
   mcmc_mod <- cmds_ecpe_lcdm
   mcmc_mod$method <- "mcmc"
 
-  err <- rlang::catch_cnd(add_criterion(mcmc_mod, "aic"))
-  expect_s3_class(err, "error_bad_method")
-  expect_match(err$message, "`method = \"optim\"`")
-
-  err <- rlang::catch_cnd(add_criterion(mcmc_mod, "bic"))
+  err <- rlang::catch_cnd(add_criterion(mcmc_mod, criterion = c("aic", "bic")))
   expect_s3_class(err, "error_bad_method")
   expect_match(err$message, "`method = \"optim\"`")
 })
diff --git a/tests/testthat/test-mcmc.R b/tests/testthat/test-mcmc.R
@@ -116,8 +116,7 @@ test_that("loo and waic can be added to model", {
   expect_equal(names(loo_model$criteria), "loo")
   expect_s3_class(loo_model$criteria$loo, "psis_loo")
 
-  lw_model <- add_criterion(loo_model, criterion = c("loo", "waic"),
-                            overwrite = TRUE)
+  lw_model <- add_criterion(loo_model, overwrite = TRUE)
   expect_equal(names(lw_model$criteria), c("loo", "waic"))
   expect_s3_class(lw_model$criteria$loo, "psis_loo")
   expect_s3_class(lw_model$criteria$waic, "waic")