Merged
Conversation
remLabels triggered labelOrderChanged via itemDropped signal during programmatic removal, creating a duplicate undo stack entry. Disconnect the signal during removal, matching the existing pattern in shapeSelectionChanged and _load_shapes.
wkentaro
force-pushed
the
fix/delete-shape-double-undo
branch
from
09a67f2 to
90f6916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itemDroppedsignal inremLabelsto prevent spuriouslabelOrderChanged→loadShapes→storeShapescreating a duplicate undo entryWhy
Deleting a shape required two undos instead of one.
removeRowsunconditionally emitsitemDropped(meant for drag-and-drop reorder), which triggeredlabelOrderChangedduring programmatic removal, creating a duplicate backup in the undo stack.Test plan
test_delete_undo_shape— single undo restores shape count and label identitytest_select_shape,test_delete_shape— existing tests still pass