test: add e2e tests for canvas interactions#1935
Merged
Conversation
Cover shape movement (drag, vertex drag, arrow keys), point editing (add on edge, remove from vertex), and drawing keyboard shortcuts (Escape to cancel, Enter to finalize).
wkentaro
force-pushed
the
test/e2e-canvas-interactions
branch
from
ba2f662 to
e1906d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image_to_widget_poshelper totests/e2e/conftest.pyWhy
canvas.py coverage was 71% and shape.py was 84%. These tests exercise realistic
user interactions (dragging shapes, moving vertices, arrow-key nudge, adding/removing
points on edges, Escape to cancel, Enter to finalize) and bring coverage to 80% and
88% respectively.
Test plan
make test— 101 passedmake lint— all checks passeduv run pytest) and offscreen (QT_QPA_PLATFORM=offscreen)