refactor: rewrite code for improved clarity and consistency#1940
Closed
refactor: rewrite code for improved clarity and consistency#1940
Conversation
Rewrite various code sections across core modules for better readability, more idiomatic patterns, and consistent style: - shape.py: use IntEnum for point style/vertex mode constants, restructure control flow with guard clauses, improve variable naming - canvas.py: rewrite boundedMoveShapes with clearer clamping logic, improve offsetToCenter variable naming, restructure event handlers - app.py: simplify scaleFitWindow with explicit min-based scaling, improve deleteFile/maybeSave flow with early returns, better variable names - label_dialog.py: consolidate flag widget management, extract helper methods - file_dialog_preview.py: extract magic numbers to named constants - brightness_contrast_dialog.py: use descriptive callback naming - __main__.py: use pathlib for file detection - utils/shape.py: minor expression cleanup All tests pass. No behavioral changes.
wkentaro
force-pushed
the
refactor/rewrite-external-contributions
branch
from
b420a95 to
5ae582f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntEnumfor shape point style and vertex mode constants instead of raw integersboundedMoveShapes,offsetToCenter, event handlers), app (scaleFitWindow,deleteFile,maybeSave), and shape modulesfile_dialog_preview.pypathlibfor file detection in__main__.pylabel_dialog.pyWhy
Improve code clarity, reduce nesting depth, and adopt more consistent idiomatic Python patterns across the codebase.
Test plan
make test)