Catch exceptions when creating constants for sd card directories#619
Catch exceptions when creating constants for sd card directories#619chrusart wants to merge 1 commit intowkh237:masterfrom flatfox-ag:sdcard_dirs
Conversation
…o get sd card directories. sd card directiories as constants deprecated warning
|
Please merge this PR. Our production app breaking this, needed asap. |
|
There is a 'RNFB MAINTAINER GONE MISSING' notice, it can take some time to merge. |
|
@chrusart any idea how much time it will take ? Looking forward to have this change released to npm. |
|
No idea, I'm not related to maintainers. |
|
We use our branch in production now, we don't get this crashes anymore and also some iOS crashes fixed: |
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. NOTE: Patches should be against the current development branch, not against |
Setting
SDCardApplicationDirconstant throws sometimesNullPointerException.Additionally
SDCardDirandSDCardApplicationDirare set once on module load, but external storage can be ejected, unmounted and paths could be not valid anymore later.This PR:
NullPointerException(and other exceptions) and sets then empty path (other ideas how to handle exception are welcome) which should be handled in JS then.getSDCardDirandgetSDCardApplicationDirmethods to get this paths when needed from JS.QUESTION TO MAINTAINERS:
I've read contributing guidelines just now when was about to create PR, should I split it to separate PRs, to bug fix and feature branches. Somehow all this PR changes could or should be merged together maybe. And this is all about Android only and not sure to do all this library testing and use dev repository.