Update tax rates documentation for fix 29472 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
claudiosanches
suggested changes
Mar 26, 2021
There was a problem hiding this comment.
Changes looks good, there's only one issue with the type of the field, it's an array of strings now, so I'm suggesting to change to string[] to indicate it.
Also I'm suggesting to indicate what version we deprecated or included parameters in REST API to avoid confusing in our REST API consumers.
In the REST API entry point to update tax rates. Co-authored-by: Claudio Sanches <[email protected]>
In the REST API entry point to update tax rates.
|
Hi @claudiosanches, I've committed your suggestions and added the introduction+deprecation notices. |
claudiosanches
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
woocommerce/woocommerce#27751 and woocommerce/woocommerce#29495 introduce two new fields for the tax rates:
postcodesandcities. This pull request adds them to the documentation and also changes it so that:cityandpostcodeare deprecated.orderbyandclassfor the taxes retrieval endpoint.priorityto the list of possibleorderbyvalues for the taxes retrieval endpoint (this value was introduced in Add "postcodes" and "cities" support for the REST API tax rate creation/update endpoint woocommerce#29495).